# HG changeset patch # User Jean-Manuel Da Silva # Date 1267382953 -3600 # Node ID c775b32927ed8c55b383bd48e81ec7df74f52f6f # Parent c30c1fb7863881a734a39e534c525d7bedcb9d05 * Added some Javadoc to fix the checkstyle issues diff -r c30c1fb78638 -r c775b32927ed .classpath --- a/.classpath Sun Feb 28 19:47:50 2010 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,8 +0,0 @@ - - - - - - - - diff -r c30c1fb78638 -r c775b32927ed default.properties --- a/default.properties Sun Feb 28 19:47:50 2010 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,14 +0,0 @@ -# This file is automatically generated by Android Tools. -# Do not modify this file -- YOUR CHANGES WILL BE ERASED! -# -# This file must be checked in Version Control Systems. -# -# To customize properties used by the Ant build system use, -# "build.properties", and override values to adapt the script to your -# project structure. - -# Indicates whether an apk should be generated for each density. -split.density=false -# Project target. -target=android-7 -apk-configurations= diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/package-info.java --- a/src/com/beem/project/beem/package-info.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/package-info.java Sun Feb 28 19:49:13 2010 +0100 @@ -41,5 +41,9 @@ Head of the EIP Laboratory. */ + +/** + * This package contains BEEM's entry points. + */ package com.beem.project.beem; diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/provider/package-info.java --- a/src/com/beem/project/beem/provider/package-info.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/provider/package-info.java Sun Feb 28 19:49:13 2010 +0100 @@ -41,5 +41,9 @@ Head of the EIP Laboratory. */ + +/** + * This package contains classes concerning hypothetical providers. + */ package com.beem.project.beem.provider; diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/Chat.java --- a/src/com/beem/project/beem/ui/Chat.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/Chat.java Sun Feb 28 19:49:13 2010 +0100 @@ -402,7 +402,8 @@ /** * Constructor. */ - public BeemServiceConnection() { } + public BeemServiceConnection() { + } /** * {@inheritDoc}. @@ -411,9 +412,11 @@ public void onServiceConnected(ComponentName name, IBinder service) { mXmppFacade = IXmppFacade.Stub.asInterface(service); try { - if ((mRoster = mXmppFacade.getRoster()) != null) + mRoster = mXmppFacade.getRoster(); + if (mRoster != null) mRoster.addRosterListener(mBeemRosterListener); - if ((mChatManager = mXmppFacade.getChatManager()) != null) { + mChatManager = mXmppFacade.getChatManager(); + if (mChatManager != null) { mChatManager.addChatCreationListener(mChatManagerListener); changeCurrentChat(mContact); } diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/ContactList.java --- a/src/com/beem/project/beem/ui/ContactList.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/ContactList.java Sun Feb 28 19:49:13 2010 +0100 @@ -389,7 +389,7 @@ ViewStub stub = (ViewStub) findViewById(R.id.contactlist_stub); if (stub != null) stub.inflate(); - else + else ((LinearLayout) findViewById(R.id.contactlist_groupstub)).setVisibility(View.VISIBLE); Gallery g = (Gallery) findViewById(R.id.contactlist_banner); g.setOnItemClickListener(new OnItemClickGroupName()); @@ -828,6 +828,9 @@ Log.e(TAG, "FINALIZE"); } + /** + * Hide the groups view. + */ private void hideGroups() { ViewStub stub = (ViewStub) findViewById(R.id.contactlist_stub); if (stub == null) diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/dialogs/builders/CreatePrivacyList.java --- a/src/com/beem/project/beem/ui/dialogs/builders/CreatePrivacyList.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/dialogs/builders/CreatePrivacyList.java Sun Feb 28 19:49:13 2010 +0100 @@ -73,24 +73,21 @@ /** * Constructor. * @param context context activity. + * @param privacyListManager the privacy list manager that will be use to create our list. */ - public CreatePrivacyList(final Context context, - final IPrivacyListManager privacyListManager) { + public CreatePrivacyList(final Context context, final IPrivacyListManager privacyListManager) { super(context); LayoutInflater factory = LayoutInflater.from(context); - mTextEntryView = factory.inflate( - R.layout.privacy_list_create_dialog, null); + mTextEntryView = factory.inflate(R.layout.privacy_list_create_dialog, null); setView(mTextEntryView); mPrivacyListManager = privacyListManager; - mListNameField = (EditText) mTextEntryView.findViewById( - R.id.privacy_list_create_dialog_list_name); + mListNameField = (EditText) mTextEntryView.findViewById(R.id.privacy_list_create_dialog_list_name); setTitle(R.string.privacy_list_create_dialog_title); - setPositiveButton(R.string.privacy_list_create_dialog_create_button, - new DialogClickListener()); + setPositiveButton(R.string.privacy_list_create_dialog_create_button, new DialogClickListener()); setNegativeButton(R.string.CancelButton, new DialogClickListener()); } @@ -120,4 +117,4 @@ } } } -} \ No newline at end of file +} diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/dialogs/builders/DeleteContact.java --- a/src/com/beem/project/beem/ui/dialogs/builders/DeleteContact.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/dialogs/builders/DeleteContact.java Sun Feb 28 19:49:13 2010 +0100 @@ -53,9 +53,13 @@ import com.beem.project.beem.service.Contact; import com.beem.project.beem.service.aidl.IRoster; +/** + * Use this builder to build a dialog which allows you to delete a contact from a specific roster. + * @author Jean-Manuel Da Silva + */ public class DeleteContact extends AlertDialog.Builder { - private final static String TAG = "Dialogs.Builders > DeleteContact"; + private static final String TAG = "Dialogs.Builders > DeleteContact"; private IRoster mRoster; private Contact mContact; @@ -63,9 +67,10 @@ /** * Constructor. * @param context context activity. + * @param roster the roster which has the contact you want to delete. + * @param contact the contact to delete. */ - public DeleteContact(final Context context, final IRoster roster, - final Contact contact) { + public DeleteContact(final Context context, final IRoster roster, final Contact contact) { super(context); mContact = contact; diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/dialogs/builders/DeletePrivacyList.java --- a/src/com/beem/project/beem/ui/dialogs/builders/DeletePrivacyList.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/dialogs/builders/DeletePrivacyList.java Sun Feb 28 19:49:13 2010 +0100 @@ -52,6 +52,10 @@ import com.beem.project.beem.R; import com.beem.project.beem.service.aidl.IPrivacyListManager; +/** + * Use this builder to build a dialog which allows you to delete a privacy list. + * @author Jean-Manuel Da Silva + */ public class DeletePrivacyList extends AlertDialog.Builder { private static final String TAG = "Dialogs.Builders > DeletePrivacyList"; @@ -62,16 +66,17 @@ /** * Constructor. * @param context context activity. + * @param privacyListManager the privacy list manager managing the privacy list you want to delete. + * @param privacyListName the name of the privacy list you want to delete. */ - public DeletePrivacyList(final Context context, - final IPrivacyListManager privacyListManager, final String privacyListName) { + public DeletePrivacyList(final Context context, final IPrivacyListManager privacyListManager, + final String privacyListName) { super(context); mPrivacyListManager = privacyListManager; mPrivacyListName = privacyListName; - setMessage(context.getString( - R.string.privacy_list_delete_dialog_msg, privacyListName)); + setMessage(context.getString(R.string.privacy_list_delete_dialog_msg, privacyListName)); DialogClickListener dl = new DialogClickListener(); setPositiveButton(R.string.privacy_list_delete_dialog_yes, dl); setNegativeButton(R.string.privacy_list_delete_dialog_no, dl); diff -r c30c1fb78638 -r c775b32927ed src/com/beem/project/beem/ui/dialogs/builders/ResendSubscription.java --- a/src/com/beem/project/beem/ui/dialogs/builders/ResendSubscription.java Sun Feb 28 19:47:50 2010 +0100 +++ b/src/com/beem/project/beem/ui/dialogs/builders/ResendSubscription.java Sun Feb 28 19:49:13 2010 +0100 @@ -57,9 +57,13 @@ import com.beem.project.beem.service.PresenceAdapter; import com.beem.project.beem.service.aidl.IXmppFacade; +/** + * Use this builder to build a dialog which allows you resend a subscription query to a contact. + * @author Jean-Manuel Da Silva + */ public class ResendSubscription extends AlertDialog.Builder { - private final static String TAG = "Dialogs.Builders > ResendSubscription"; + private static final String TAG = "Dialogs.Builders > ResendSubscription"; private Context mContext; private IXmppFacade mXmppFacade; @@ -67,10 +71,11 @@ /** * Constructor. - * @param context context activity + * @param context context activity. + * @param xmppFacade the XMPP Facade used to send the query. + * @param contact the receiver of the query. */ - public ResendSubscription(final Context context, - final IXmppFacade xmppFacade, final Contact contact) { + public ResendSubscription(final Context context, final IXmppFacade xmppFacade, final Contact contact) { super(context); mContext = context; @@ -100,10 +105,8 @@ Presence presencePacket = new Presence(Presence.Type.subscribe); presencePacket.setTo(mContact.getJID()); try { - mXmppFacade.sendPresencePacket( - new PresenceAdapter(presencePacket)); - Toast.makeText(mContext, mContext.getString( - R.string.userinfo_resend), Toast.LENGTH_SHORT).show(); + mXmppFacade.sendPresencePacket(new PresenceAdapter(presencePacket)); + Toast.makeText(mContext, mContext.getString(R.string.userinfo_resend), Toast.LENGTH_SHORT).show(); } catch (RemoteException e) { Log.e(TAG, e.getMessage()); } diff -r c30c1fb78638 -r c775b32927ed tools/checkstyle.xml --- a/tools/checkstyle.xml Sun Feb 28 19:47:50 2010 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,341 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -